SNOW-2220946: Add support for unstructured data engineering in Snowpark#3775
Conversation
| WriteParquet write_parquet = 182; | ||
| WriteSave write_save = 183; | ||
| WriteTable write_table = 184; | ||
| DataframeAiAgg dataframe_ai_agg = 47; |
There was a problem hiding this comment.
Are we concerned with these constants changing? Normally I would add to the end and increment to prevent version incompatibilities but I'm not sure if it matters with how the AST is used today.
There was a problem hiding this comment.
AST change was already reviewed in this PR https://github.com/snowflakedb/snowpark-python/pull/3761/files
There was a problem hiding this comment.
This file is autogenerated, the constants shouldn't pose any issues until we start versioning the AST.
| @@ -1,5 +1,29 @@ | |||
| # Release History | |||
|
|
|||
| ## 1.40.0 (YYYY-MM-DD) | |||
There was a problem hiding this comment.
you don't want this to go out with 1.39.0?
There was a problem hiding this comment.
Yea 1.39 will be this week, right? I'm not sure whether we can finish review by this week.
| def __init__(self, dataframe: "snowflake.snowpark.DataFrame") -> None: | ||
| self._dataframe = dataframe | ||
|
|
||
| @experimental(version="1.40.0") |
There was a problem hiding this comment.
this also need to be changed to 1.39 if want to included in this release
| df._ast_id = stmt.uid | ||
| return df | ||
|
|
||
| @experimental(version="1.40.0") |
| filtered_df._ast_id = stmt.uid | ||
| return filtered_df | ||
|
|
||
| @experimental(version="1.40.0") |
| df._ast_id = stmt.uid | ||
| return df | ||
|
|
||
| @experimental(version="1.40.0") |
| df._ast_id = stmt.uid | ||
| return df | ||
|
|
||
| @experimental(version="1.40.0") |
| df._ast_id = stmt.uid | ||
| return df | ||
|
|
||
| @experimental(version="1.40.0") |
| df._ast_id = stmt.uid | ||
| return df | ||
|
|
||
| @experimental(version="1.40.0") |
| df._ast_id = stmt.uid | ||
| return df | ||
|
|
||
| @experimental(version="1.40.0") |
| df._ast_id = stmt.uid | ||
| return df | ||
|
|
||
| @experimental(version="1.40.0") |
| df._ast_id = stmt.uid | ||
| return df | ||
|
|
||
| @experimental(version="1.40.0") |
There was a problem hiding this comment.
There are also some place need to change below
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2220946
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
see changelog